Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: give more options for building in README.md #18468

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

redsun82
Copy link
Contributor

No description provided.

@Copilot Copilot bot review requested due to automatic review settings January 10, 2025 10:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@github-actions github-actions bot added documentation Rust Pull requests that update Rust code labels Jan 10, 2025
Copy link
Contributor

@paldepind paldepind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to have better docs 😃

I've left a few minor comments.

rust/README.md Outdated Show resolved Hide resolved
rust/README.md Outdated Show resolved Hide resolved
rust/README.md Outdated Show resolved Hide resolved
rust/README.md Outdated Show resolved Hide resolved

Sometimes, especially if resolving conflicts on generated files, you might need to run
```bash
bazel run @codeql//rust/codegen -- --force
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great to have this documented 👍. I struggled with that until I found the --force flag.

Co-authored-by: Simon Friis Vindum <simonfv@gmail.com>
@redsun82 redsun82 requested a review from paldepind January 22, 2025 13:57
Copy link
Contributor

@paldepind paldepind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for writing this down 🙏

@redsun82
Copy link
Contributor Author

Looks great. Thanks for writing this down 🙏

@paldepind you might have forgotten to approve the PR then 😆

@redsun82 redsun82 requested a review from paldepind January 22, 2025 16:22
@paldepind
Copy link
Contributor

Oops, sorry 😅. Approved now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants