Rust: Convert source models to models-as-data #18530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
added
no-change-note-required
There was a problem hiding this comment.
Copilot reviewed 3 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (7)
- rust/ql/lib/codeql/rust/Concepts.qll: Language not supported
- rust/ql/lib/codeql/rust/Frameworks.qll: Language not supported
- rust/ql/lib/codeql/rust/frameworks/Reqwest.qll: Language not supported
- rust/ql/lib/codeql/rust/frameworks/stdlib/Env.qll: Language not supported
- rust/ql/lib/codeql/rust/security/WeakSensitiveDataHashingExtensions.qll: Language not supported
- rust/ql/test/library-tests/dataflow/sources/TaintSources.expected: Language not supported
- rust/ql/test/library-tests/dataflow/taint/TaintFlowStep.expected: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
hvitved
reviewed
Jan 20, 2025
|
DCA was uneventful. |
hvitved
approved these changes
Jan 22, 2025
|
Merge was broken by the "MaD:X" entry in the |
|
Thanks for approving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert existing source models to models-as-data. This will allow the sources to be made more accurate w.r.t. the
OptionandResultcontent they return - which I will do in a follow-up PR.@paldepind FYI